Refactor PartitionsSaxHandler to use boost::json#1670
Open
asopov-here wants to merge 6 commits intofeature_boost_jsonfrom
Open
Refactor PartitionsSaxHandler to use boost::json#1670asopov-here wants to merge 6 commits intofeature_boost_jsonfrom
asopov-here wants to merge 6 commits intofeature_boost_jsonfrom
Conversation
asopov-here
force-pushed
the
task/OCMAM-448
branch
3 times, most recently
from
15b17c6 to
f501541
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature_boost_json #1670 +/- ##
=====================================================
Coverage ? 80.39%
=====================================================
Files ? 351
Lines ? 14071
Branches ? 1517
=====================================================
Hits ? 11312
Misses ? 2146
Partials ? 613 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asopov-here
force-pushed
the
task/OCMAM-448
branch
4 times, most recently
from
5a1ab0f to
79db427
Compare
Previously it was based on rapidjson The tests are adjusted accordingly. Relates-To: OCMAM-448 Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
asopov-here
force-pushed
the
task/OCMAM-448
branch
from
79db427 to
8a4b4e2
Compare
Previously it was based on rapidjson The tests are adjusted accordingly. Relates-To: OCMAM-448 Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Previously it was based on rapidjson The tests are adjusted accordingly. Relates-To: OCMAM-448 Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
asopov-here
force-pushed
the
task/OCMAM-448
branch
from
2220516 to
0dd7313
Compare
Previously it was based on rapidjson The tests are adjusted accordingly. Relates-To: OCMAM-448 Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
| namespace repository { | ||
|
|
||
| /// Json byte stream class. Implements rapidjson input stream concept. | ||
| class RapidJsonByteStream { |
Contributor
There was a problem hiding this comment.
This one is no longer rapidjson then
Contributor
Author
There was a problem hiding this comment.
Technically it's still rapidjoson-compliant. :)
olp-cpp-sdk-dataservice-read/src/repositories/AsyncJsonStream.cpp
Outdated
Show resolved
Hide resolved
olp-cpp-sdk-dataservice-read/src/repositories/PartitionsRepository.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| parse_result = reader.Parse<rapidjson::kParseIterativeFlag>( | ||
| *json_stream, *partitions_handler); | ||
| while (json_stream->Peek() != '\0') { |
Contributor
There was a problem hiding this comment.
Maybe better to have separate function for end detection?
Previously it was based on rapidjson The tests are adjusted accordingly. Relates-To: OCMAM-448 Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Previously it was based on rapidjson The tests are adjusted accordingly. Relates-To: OCMAM-448 Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
asopov-here
force-pushed
the
task/OCMAM-448
branch
from
d6e83d5 to
becba7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates-To: OCMAM-448